Return StarterPackView instead of StarterPackViewBasic from getSuggestedStarterPacks (#3706)

2025-04-01 15:58:55 -05:00 · 2025-04-01 15:58:55 -05:00 · 04b6230cd2
commit 04b6230cd2
parent a26813da21
13 changed files with 20 additions and 17 deletions
--- a/.changeset/little-snakes-repair.md
+++ b/.changeset/little-snakes-repair.md
@ -0,0 +1,6 @@
+---
+"@atproto/bsky": patch
+"@atproto/api": patch
+---
+
+Return `StarterPackView` instead of `StarterPackViewBasic` from `getSuggestedStarterPacks`
--- a/lexicons/app/bsky/unspecced/getSuggestedStarterPacks.json
+++ b/lexicons/app/bsky/unspecced/getSuggestedStarterPacks.json
@ -26,7 +26,7 @@
              "type": "array",
              "items": {
                "type": "ref",
-                "ref": "app.bsky.graph.defs#starterPackViewBasic"
+                "ref": "app.bsky.graph.defs#starterPackView"
              }
            }
          }
--- a/packages/api/src/client/lexicons.ts
+++ b/packages/api/src/client/lexicons.ts
@ -9912,7 +9912,7 @@ export const schemaDict = {
                type: 'array',
                items: {
                  type: 'ref',
-                  ref: 'lex:app.bsky.graph.defs#starterPackViewBasic',
+                  ref: 'lex:app.bsky.graph.defs#starterPackView',
                },
              },
            },
--- a/packages/api/src/client/types/app/bsky/unspecced/getSuggestedStarterPacks.ts
+++ b/packages/api/src/client/types/app/bsky/unspecced/getSuggestedStarterPacks.ts
@ -23,7 +23,7 @@ export interface QueryParams {
 export type InputSchema = undefined

 export interface OutputSchema {
-  starterPacks: AppBskyGraphDefs.StarterPackViewBasic[]
+  starterPacks: AppBskyGraphDefs.StarterPackView[]
 }

 export interface CallOptions {
--- a/packages/bsky/src/api/app/bsky/unspecced/getSuggestedStarterPacks.ts
+++ b/packages/bsky/src/api/app/bsky/unspecced/getSuggestedStarterPacks.ts
@ -89,10 +89,7 @@ const hydration = async (
    pairs.set(params.viewer, dids)
  }
  const [starterPacksState, bidirectionalBlocks] = await Promise.all([
-    ctx.hydrator.hydrateStarterPacksBasic(
-      skeleton.starterPacks,
-      params.hydrateCtx,
-    ),
+    ctx.hydrator.hydrateStarterPacks(skeleton.starterPacks, params.hydrateCtx),
    ctx.hydrator.hydrateBidirectionalBlocks(pairs),
  ])

@ -129,7 +126,7 @@ const presentation = (

  return {
    starterPacks: mapDefined(skeleton.starterPacks, (uri) =>
-      ctx.views.starterPackBasic(uri, hydration),
+      ctx.views.starterPack(uri, hydration),
    ),
  }
 }
--- a/packages/bsky/src/lexicon/lexicons.ts
+++ b/packages/bsky/src/lexicon/lexicons.ts
@ -9912,7 +9912,7 @@ export const schemaDict = {
                type: 'array',
                items: {
                  type: 'ref',
-                  ref: 'lex:app.bsky.graph.defs#starterPackViewBasic',
+                  ref: 'lex:app.bsky.graph.defs#starterPackView',
                },
              },
            },
--- a/packages/bsky/src/lexicon/types/app/bsky/unspecced/getSuggestedStarterPacks.ts
+++ b/packages/bsky/src/lexicon/types/app/bsky/unspecced/getSuggestedStarterPacks.ts
@ -24,7 +24,7 @@ export interface QueryParams {
 export type InputSchema = undefined

 export interface OutputSchema {
-  starterPacks: AppBskyGraphDefs.StarterPackViewBasic[]
+  starterPacks: AppBskyGraphDefs.StarterPackView[]
 }

 export type HandlerInput = undefined
--- a/packages/bsky/tests/seed/get-suggested-starter-packs.ts
+++ b/packages/bsky/tests/seed/get-suggested-starter-packs.ts
@ -36,7 +36,7 @@ const users = {
 export type Users = typeof users
 export type StarterPacks = SeedClient['starterpacks']

-export async function trendsSeed(
+export async function starterPacksSeed(
  sc: SeedClient<TestNetwork | TestNetworkNoAppView>,
 ) {
  const u = structuredClone(users)
--- a/packages/bsky/tests/views/get-suggested-starter-packs.test.ts
+++ b/packages/bsky/tests/views/get-suggested-starter-packs.test.ts
@ -9,7 +9,7 @@ import { OutputSchema } from '../../src/lexicon/types/app/bsky/unspecced/getSugg
 import {
  StarterPacks,
  Users,
-  trendsSeed,
+  starterPacksSeed,
 } from '../seed/get-suggested-starter-packs'

 describe('getSuggestedStarterPacks', () => {
@ -34,7 +34,7 @@ describe('getSuggestedStarterPacks', () => {
    agent = network.bsky.getClient()
    sc = network.getSeedClient()

-    const result = await trendsSeed(sc)
+    const result = await starterPacksSeed(sc)
    users = result.users
    starterpacks = result.starterpacks

--- a/packages/ozone/src/lexicon/lexicons.ts
+++ b/packages/ozone/src/lexicon/lexicons.ts
@ -9912,7 +9912,7 @@ export const schemaDict = {
                type: 'array',
                items: {
                  type: 'ref',
-                  ref: 'lex:app.bsky.graph.defs#starterPackViewBasic',
+                  ref: 'lex:app.bsky.graph.defs#starterPackView',
                },
              },
            },
--- a/packages/ozone/src/lexicon/types/app/bsky/unspecced/getSuggestedStarterPacks.ts
+++ b/packages/ozone/src/lexicon/types/app/bsky/unspecced/getSuggestedStarterPacks.ts
@ -24,7 +24,7 @@ export interface QueryParams {
 export type InputSchema = undefined

 export interface OutputSchema {
-  starterPacks: AppBskyGraphDefs.StarterPackViewBasic[]
+  starterPacks: AppBskyGraphDefs.StarterPackView[]
 }

 export type HandlerInput = undefined
--- a/packages/pds/src/lexicon/lexicons.ts
+++ b/packages/pds/src/lexicon/lexicons.ts
@ -9912,7 +9912,7 @@ export const schemaDict = {
                type: 'array',
                items: {
                  type: 'ref',
-                  ref: 'lex:app.bsky.graph.defs#starterPackViewBasic',
+                  ref: 'lex:app.bsky.graph.defs#starterPackView',
                },
              },
            },
--- a/packages/pds/src/lexicon/types/app/bsky/unspecced/getSuggestedStarterPacks.ts
+++ b/packages/pds/src/lexicon/types/app/bsky/unspecced/getSuggestedStarterPacks.ts
@ -24,7 +24,7 @@ export interface QueryParams {
 export type InputSchema = undefined

 export interface OutputSchema {
-  starterPacks: AppBskyGraphDefs.StarterPackViewBasic[]
+  starterPacks: AppBskyGraphDefs.StarterPackView[]
 }

 export type HandlerInput = undefined