50c0ec176c
* add scopes to service auth impl * add error to getServiceAuth * send scoped tokens from pds * clean up privileged access scopes & allow simple service auth tokens for app passwords * integration into ozone * fix up bsky tests * cleanup xrpc-server tests * fix up tests & types * one more test * fix read after write tests * fix mod auth test * convert scopes to be a single method name * add scope check callback for auth verifier * pds changes only * fix feed generation tests * use scope for ozone service profile * dont verify scopes on pds yet * tidy * tidy imports * changeset * add tests * tidy * another changeset * scope -> lxm * tidy * clean up scope references * update nonce size * pr feedback * trim trailing slash * nonce -> jti * fix xrpc-server test * allow service auth on uploadBlob * fix build error * changeset * build, tidy * xrpc-server: update lxm claim check error * appview: temporarily permit labeler service calls to omit lxm claim * xrpc-server: fix test * changeset * fix merged tests --------- Co-authored-by: Devin Ivy <devinivy@gmail.com>
190 lines
5.3 KiB
TypeScript
190 lines
5.3 KiB
TypeScript
import { SeedClient, usersSeed, TestNetwork } from '@atproto/dev-env'
|
|
import { AtpAgent } from '@atproto/api'
|
|
import { Secp256k1Keypair } from '@atproto/crypto'
|
|
import { createServiceAuthHeaders } from '@atproto/xrpc-server'
|
|
import { RepoRef } from '../../src/lexicon/types/com/atproto/admin/defs'
|
|
import { ids } from '../../src/lexicon/lexicons'
|
|
|
|
describe('admin auth', () => {
|
|
let network: TestNetwork
|
|
let agent: AtpAgent
|
|
let sc: SeedClient
|
|
|
|
let repoSubject: RepoRef
|
|
|
|
const modServiceDid = 'did:example:mod'
|
|
const altModDid = 'did:example:alt'
|
|
let modServiceKey: Secp256k1Keypair
|
|
let bskyDid: string
|
|
|
|
beforeAll(async () => {
|
|
network = await TestNetwork.create({
|
|
dbPostgresSchema: 'bsky_admin_auth',
|
|
bsky: {
|
|
modServiceDid,
|
|
},
|
|
})
|
|
|
|
bskyDid = network.bsky.ctx.cfg.serverDid
|
|
|
|
modServiceKey = await Secp256k1Keypair.create()
|
|
const origResolve = network.bsky.dataplane.idResolver.did.resolve
|
|
network.bsky.dataplane.idResolver.did.resolve = async function (
|
|
did: string,
|
|
forceRefresh?: boolean,
|
|
) {
|
|
if (did === modServiceDid || did === altModDid) {
|
|
return {
|
|
'@context': [
|
|
'https://www.w3.org/ns/did/v1',
|
|
'https://w3id.org/security/multikey/v1',
|
|
'https://w3id.org/security/suites/secp256k1-2019/v1',
|
|
],
|
|
id: did,
|
|
verificationMethod: [
|
|
{
|
|
id: `${did}#atproto`,
|
|
type: 'Multikey',
|
|
controller: did,
|
|
publicKeyMultibase: modServiceKey.did().replace('did:key:', ''),
|
|
},
|
|
],
|
|
}
|
|
}
|
|
return origResolve.call(this, did, forceRefresh)
|
|
}
|
|
|
|
agent = network.bsky.getClient()
|
|
sc = network.getSeedClient()
|
|
await usersSeed(sc)
|
|
await network.processAll()
|
|
repoSubject = {
|
|
$type: 'com.atproto.admin.defs#repoRef',
|
|
did: sc.dids.bob,
|
|
}
|
|
})
|
|
|
|
afterAll(async () => {
|
|
await network.close()
|
|
})
|
|
|
|
it('allows service auth requests from the configured appview did', async () => {
|
|
const updateHeaders = await createServiceAuthHeaders({
|
|
iss: modServiceDid,
|
|
aud: bskyDid,
|
|
lxm: ids.ComAtprotoAdminUpdateSubjectStatus,
|
|
keypair: modServiceKey,
|
|
})
|
|
await agent.api.com.atproto.admin.updateSubjectStatus(
|
|
{
|
|
subject: repoSubject,
|
|
takedown: { applied: true, ref: 'test-repo' },
|
|
},
|
|
{
|
|
...updateHeaders,
|
|
encoding: 'application/json',
|
|
},
|
|
)
|
|
|
|
const getHeaders = await createServiceAuthHeaders({
|
|
iss: modServiceDid,
|
|
aud: bskyDid,
|
|
lxm: ids.ComAtprotoAdminGetSubjectStatus,
|
|
keypair: modServiceKey,
|
|
})
|
|
const res = await agent.api.com.atproto.admin.getSubjectStatus(
|
|
{ did: repoSubject.did },
|
|
getHeaders,
|
|
)
|
|
expect(res.data.subject.did).toBe(repoSubject.did)
|
|
expect(res.data.takedown?.applied).toBe(true)
|
|
})
|
|
|
|
it('does not allow requests from another did', async () => {
|
|
const headers = await createServiceAuthHeaders({
|
|
iss: altModDid,
|
|
aud: bskyDid,
|
|
lxm: ids.ComAtprotoAdminUpdateSubjectStatus,
|
|
keypair: modServiceKey,
|
|
})
|
|
const attempt = agent.api.com.atproto.admin.updateSubjectStatus(
|
|
{
|
|
subject: repoSubject,
|
|
takedown: { applied: true, ref: 'test-repo' },
|
|
},
|
|
{
|
|
...headers,
|
|
encoding: 'application/json',
|
|
},
|
|
)
|
|
await expect(attempt).rejects.toThrow('Untrusted issuer')
|
|
})
|
|
|
|
it('does not allow requests from an authenticated user', async () => {
|
|
const aliceKey = await network.pds.ctx.actorStore.keypair(sc.dids.alice)
|
|
const headers = await createServiceAuthHeaders({
|
|
iss: sc.dids.alice,
|
|
aud: bskyDid,
|
|
lxm: ids.ComAtprotoAdminUpdateSubjectStatus,
|
|
keypair: aliceKey,
|
|
})
|
|
const attempt = agent.api.com.atproto.admin.updateSubjectStatus(
|
|
{
|
|
subject: repoSubject,
|
|
takedown: { applied: true, ref: 'test-repo' },
|
|
},
|
|
{
|
|
...headers,
|
|
encoding: 'application/json',
|
|
},
|
|
)
|
|
await expect(attempt).rejects.toThrow('Untrusted issuer')
|
|
})
|
|
|
|
it('does not allow requests with a bad signature', async () => {
|
|
const badKey = await Secp256k1Keypair.create()
|
|
const headers = await createServiceAuthHeaders({
|
|
iss: modServiceDid,
|
|
aud: bskyDid,
|
|
lxm: ids.ComAtprotoAdminUpdateSubjectStatus,
|
|
keypair: badKey,
|
|
})
|
|
const attempt = agent.api.com.atproto.admin.updateSubjectStatus(
|
|
{
|
|
subject: repoSubject,
|
|
takedown: { applied: true, ref: 'test-repo' },
|
|
},
|
|
{
|
|
...headers,
|
|
encoding: 'application/json',
|
|
},
|
|
)
|
|
await expect(attempt).rejects.toThrow(
|
|
'jwt signature does not match jwt issuer',
|
|
)
|
|
})
|
|
|
|
it('does not allow requests with a bad aud', async () => {
|
|
// repo subject is bob, so we set alice as the audience
|
|
const headers = await createServiceAuthHeaders({
|
|
iss: modServiceDid,
|
|
aud: sc.dids.alice,
|
|
lxm: ids.ComAtprotoAdminUpdateSubjectStatus,
|
|
keypair: modServiceKey,
|
|
})
|
|
const attempt = agent.api.com.atproto.admin.updateSubjectStatus(
|
|
{
|
|
subject: repoSubject,
|
|
takedown: { applied: true, ref: 'test-repo' },
|
|
},
|
|
{
|
|
...headers,
|
|
encoding: 'application/json',
|
|
},
|
|
)
|
|
await expect(attempt).rejects.toThrow(
|
|
'jwt audience does not match service did',
|
|
)
|
|
})
|
|
})
|