lamp/puppeteer-discord-bot
lamp/puppeteer-discord-bot
1
2
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fullPage: true? #9

Closed
Abcmsaj wants to merge 1 commits from patch-1 into master
pull from: patch-1
merge into: lamp:master
Conversation 3 Commits 1 Files Changed 1 +1 -1
Abcmsaj commented 2020-09-01 18:14:38 -05:00 (Migrated from github.com)
Copy Link

Unsure if you were aware but passing fullPage: true into the page.screenshot command will return the whole page. Really useful for some websites like Wikipedia where you may want more info. Perhaps you could add it as an optional arg to the command?

Unsure if you were aware but passing fullPage: true into the page.screenshot command will return the whole page. Really useful for some websites like Wikipedia where you may want more info. Perhaps you could add it as an optional arg to the command?
Abcmsaj commented 2020-09-01 18:15:44 -05:00 (Migrated from github.com)
Copy Link

Really cool project btw. I've spent the last week making my own Discord.js bot for a Fantasy Football group and had no idea I could integrate with Puppeteer to post screenshots to the channel - you've saved me a ton of time, thank you!

Really cool project btw. I've spent the last week making my own Discord.js bot for a Fantasy Football group and had no idea I could integrate with Puppeteer to post screenshots to the channel - you've saved me a ton of time, thank you!
lamp commented 2020-09-02 20:44:48 -05:00
Copy Link

good idea; I should add a flag parser; I would also like a flag to specify viewport

good idea; I should add a flag parser; I would also like a flag to specify viewport
lamp commented 2021-07-10 00:15:15 -05:00
Copy Link

closed with 71fe7a19d7

closed with 71fe7a19d736206b3843404926b1d230ea014f22

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lamp/puppeteer-discord-bot#9
No description provided.
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?